Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable openssf compiler options #8998

Merged

Conversation

garazdawi
Copy link
Contributor

This PR enabled the OpenSSF compiler hardening options on github actions and fixes a bunch of warnings found when enabling it.

@garazdawi garazdawi added team:VM Assigned to OTP team VM enhancement fix labels Oct 28, 2024
@garazdawi garazdawi added this to the OTP-28.0 milestone Oct 28, 2024
@garazdawi garazdawi self-assigned this Oct 28, 2024
Copy link
Contributor

github-actions bot commented Oct 28, 2024

CT Test Results

   13 files    260 suites   3h 26m 31s ⏱️
3 111 tests 2 960 ✅ 151 💤 0 ❌
4 594 runs  4 191 ✅ 403 💤 0 ❌

Results for commit fc9509e.

♻️ This comment has been updated with latest results.

To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass.

See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally.

Artifacts

// Erlang/OTP Github Action Bot

@garazdawi garazdawi added the testing currently being tested, tag is used by OTP internal CI label Oct 29, 2024
@garazdawi garazdawi force-pushed the lukas/gh/enable-openssf-compiler-options branch from e1ba94e to 74de3af Compare November 6, 2024 12:27
@garazdawi garazdawi force-pushed the lukas/gh/enable-openssf-compiler-options branch from 74de3af to 63b7182 Compare November 7, 2024 13:48
@garazdawi garazdawi requested a review from sverker November 7, 2024 13:51
@kikofernandez kikofernandez self-requested a review November 8, 2024 08:31
kikofernandez
kikofernandez previously approved these changes Nov 11, 2024
Copy link
Contributor

@kikofernandez kikofernandez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! I have looked specially at the Github Action and SARIF stuff

@garazdawi garazdawi force-pushed the lukas/gh/enable-openssf-compiler-options branch from 63b7182 to 561c09b Compare November 15, 2024 12:56
@garazdawi garazdawi force-pushed the lukas/gh/enable-openssf-compiler-options branch from 561c09b to fc9509e Compare November 15, 2024 13:00
@garazdawi garazdawi merged commit be2ec3d into erlang:master Nov 18, 2024
31 checks passed
@garazdawi garazdawi deleted the lukas/gh/enable-openssf-compiler-options branch November 18, 2024 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement fix team:VM Assigned to OTP team VM testing currently being tested, tag is used by OTP internal CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants